do not allow inference in predicate_must_hold
#109558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
commented
Mar 24, 2023
| @@ -13,7 +13,6 @@ fn main() { | |||
|
|
|||
| let z: AtomicU32 = 1; | |||
| //~^ ERROR mismatched types | |||
| //~| HELP call `Into::into` on this expression to convert `{integer}` into `AtomicU32` | |||
There was a problem hiding this comment.
annoying, we don't have a placeholder for {integer} 🤔 maybe we should instead evaluate and then check whether anything has been constrained?
|
☔ The latest upstream changes (presumably #110036) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2023
…old, r=jackh726 do not allow inference in `predicate_must_hold` (alternative approach) See the FCP description for more info, but tl;dr is that we should not return `EvaluatedToOkModuloRegions` if an obligation may hold only with some choice of inference vars being constrained. Attempts to solve this in the approach laid out by lcnr here: rust-lang#109558 (comment), rather than by eagerly replacing infer vars with placeholders which is a bit too restrictive. r? `@ghost`
oli-obk
pushed a commit
to oli-obk/miri
that referenced
this pull request
May 23, 2023
…ckh726 do not allow inference in `predicate_must_hold` (alternative approach) See the FCP description for more info, but tl;dr is that we should not return `EvaluatedToOkModuloRegions` if an obligation may hold only with some choice of inference vars being constrained. Attempts to solve this in the approach laid out by lcnr here: rust-lang/rust#109558 (comment), rather than by eagerly replacing infer vars with placeholders which is a bit too restrictive. r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? types